Boxing and unboxing of multi npmbox archives

arei / npmbox

Utility for creating (boxing) and using (unboxing) an archive of a complete (including all dependencies) npm install.

MIT License

245 stars 34 forks source link

Boxing and unboxing of multi npmbox archives #58

Closed moci closed 8 years ago

moci commented 8 years ago

Boxing multiple packages results in a so called 'multi-npmbox' file. This file has the same extension as other npmbox files but internally includes the invididual 'single-npmbox' files of the individual packages.
Unboxing npmbox files, naturally, also supports these new 'multi-npmbox' files. The files provided to npmunbox can be a mixture of single and multi npmbox files.

There is however an issue with the tar.gz dependency. It will not correctly extract the multi-npmbox files. Using a previous version (1.0.2) has been found to improve the situation (but not fix it entirely), this is a known issue: https://github.com/alanhoff/node-tar.gz/issues/35

arei commented 8 years ago

@moci Please don;t take this the wrong way, but I am going to close this PR without accepting it. You code was fine and while I was reviewing it I noticed a way to do the same thing but to do it more cleanly, cover more use cases, and be backwards compatible with older .npmbox files. So I'm going with that approach.

Again, not your code. Your stuff was solid, and totally helped me understand the better solution. I really appreciate the code and the discussion we had about it.

Please give 4.0.0 a look when I publish it and tell me what you think.

moci commented 8 years ago

No problem, I'll take credit for giving you some inspiration :). My approach is limited in that I wanted to remain true to the flow that was already there, you optimized the flow itself - much better!

arei commented 8 years ago

The big ticket was realizing how little had to change to get it there. What you said about making a tar of tars got me thinking about how we could do it inside of a single tar. Meverything after that was just a reshuffling of things.

Good solid collaboration work. Thank you again!

Gold star. :star2: