search

arei / npmbox

Utility for creating (boxing) and using (unboxing) an archive of a complete (including all dependencies) npm install.
MIT License
245 stars 34 forks source link

Better flag files #68

Closed danfuzz closed 7 years ago

danfuzz commented 8 years ago

This PR fixes the naming of flag files inside box archives, such that names for things other than unscoped packages will work. Notably, this fixes the case of doing a top-level install of a package named by a URL or Github account/repo pair.

In addition to the main thrust of the PR:

Note: I kept the spacing tweaks in a separate commit. If you'd prefer not to include that, let me know and I'll rework the PR.

BTW/FTR: This PR fixes tangentially-related problems I found while working on issue #31.

danfuzz commented 7 years ago

Integrated this PR into #71. Closing this one.