Closed rdslw closed 1 year ago
I'd ask for the dump, but that might contain sensitive information. Can you paste the output of pstack <corefile>
here?
I do have that corefile, but as You wrote, I suspect it contains some priv info. In terms of pstack, my distro does not have it, and the only version I found works on running processes (pids) not coredumps: https://code.lm7.fr/robotux/pstack
Please advise.
Hmm, I'm most likely going to have to defer this to @arekinath if he's listening, then.
Maybe:
gdb <core>
where
and that'll show you the crash-stack. It's been a while since I've used gdb, but that might yield a stack w/o giving away sensitive information.
unfortunately my pivy-agent is stripped no debug binary
Reading symbols from /usr/bin/pivy-agent...
--Type <RET> for more, q to quit, c to continue without paging--
(No debugging symbols found in /usr/bin/pivy-agent)
[New LWP 1116]
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/usr/lib/libthread_db.so.1".
Core was generated by `pivy-agent -g CENSORED'.
Program terminated with signal SIGSEGV, Segmentation fault.
#0 0x00007ef5c95982a2 in fread () from /usr/lib/libc.so.6
(gdb) bt
#0 0x00007ef5c95982a2 in fread () from /usr/lib/libc.so.6
#1 0x000057dc214d42b5 in ?? ()
#2 0x000057dc214d3187 in ?? ()
#3 0x00007ef5c954b310 in __libc_start_call_main () from /usr/lib/libc.so.6
#4 0x00007ef5c954b3c1 in __libc_start_main_impl () from /usr/lib/libc.so.6
#5 0x000057dc214d31ce in ?? ()
(gdb)
Well, that's not a lot to go on. But looking over the code, there is one place in the pivy-agent code where we could crash in fread()
because of a missing check on the return value of fopen()
(on a file in /proc
in the Linux-specific code, if the process which is trying to connect to pivy-agent
crashes or gives up really quickly and immediately exits)
I can't say for sure if that's what happened here, but it's a bug anyway, so I've pushed a fix for it as https://github.com/arekinath/pivy/commit/74daf14723c5dc30395374cae0474433976e1ef5
Thank you @arekinath . From your description and symptoms I've seen this may be it. It was ssh-add (external process connecting to pivy-agent) while either terminated, or timeouted without input. So it may be it.
Any new release planned soon, or shall I try to built from master?
I was using 0.9.0 with manual patch with https://github.com/arekinath/pivy/commit/74daf14723c5dc30395374cae0474433976e1ef5 and did not observe this behaviour anymore.
Closing as looks as fixed. Will reopen in case of problems, but think not :)
during ssh-add -X (pin entering) either it hanged or sth happened during/after entering pin (to unlock yubikey rsa keys) and pivy-agent crashed with core dumped.