arekinath / pivy

Tools for using PIV tokens (like Yubikeys) as an SSH agent, for encrypting data at rest, and more
193 stars 26 forks source link

pivy-tool setup should reject unexpected arguments #34

Closed jclulow closed 1 year ago

jclulow commented 1 year ago
$ pivy-tool setup --help
pivy-tool: invalid option -- '-'
pivy-tool: invalid option -- 'h'
pivy-tool: invalid option -- 'e'
pivy-tool: invalid option -- 'l'
Initializing CCC and CHUID files...
24FE845F922459CE34CA803F8B384DED
Generating standard keys...
ecdsa-sha2-nistp256 AAAAE2VjZHNhLXNoYTItbmlzdHAyNTYAAAAIbmlzdHAyNTYAAABBBL6rSly7baeTsgLRXUjH6gTpaV2BNDIzSQRmZRZIE08Q0kpI3vxWJ1rham2jFlqtdGV6Axe47519o3CeZRXBGVg= PIV_slot_9E@24FE845F922459CE34CA803F8B384DED
ecdsa-sha2-nistp256 AAAAE2VjZHNhLXNoYTItbmlzdHAyNTYAAAAIbmlzdHAyNTYAAABBBNJ8p4cgJshkaKb5W3QY0nVq2klVeHec5I/0xjcnYviqc7kqyuw9DfKe+TqJ+bkDaInzLtRRatfZBjiF/J2WIfA= PIV_slot_9A@24FE845F922459CE34CA803F8B384DED
arekinath commented 1 year ago

This turns out to apply to all of the pivy-tool commands. 163540ace46992a53567a38ef4ebe84489c29db1 should fix it for all of them (and also contains some tweaks to make pivy-tool setup a little safer to use)