arekinath / pivy

Tools for using PIV tokens (like Yubikeys) as an SSH agent, for encrypting data at rest, and more
193 stars 26 forks source link

fix: remove invalid algorithm #39

Closed aiotter closed 1 year ago

aiotter commented 1 year ago

RSA4096 seems no longer supported.

$ pivy-tool -a rsa4096 -i once generate 9a
pivy-tool: failed to parse -a
  Caused by InvalidAlgorithm: Invalid/unknown algorithm name: 'rsa4096'
    in piv_alg_from_string() at piv.c:5932

It is not listed on piv_alg_from_string function: https://github.com/arekinath/pivy/blob/4fbe5beb2642d80c14d3b3109ef2a2ccd8cb4169/piv.c#L6007-L6044

arekinath commented 1 year ago

Thanks for spotting this one!