search

areknawo / webpack-suit-up

Simple CLI for generating Webpack configuration boilerplate ⚡
MIT License
8 stars 3 forks source link

PWA in cli #1

Open northkode opened 5 years ago

northkode commented 5 years ago

would be cool if the cli guided the user through PWA support as well

areknawo commented 5 years ago

As far as I know, Webpack support for PWA can be only done for service worker and manifest file. Are there any more PWA features that could be implemented? If not, it's only a matter of some additional plugins and prompts.

northkode commented 5 years ago

There are workbox configurations as well as the manifest configs. but that might be out of scope for the CLI, even if it just said, enable PWA true | false and did the imports would be handy.

Also I would recommend doing PWA support for PRODUCTION or UAT webpack configs only so development of the application doesn't install the service worker for each webpack reload. Just a thought.

areknawo commented 5 years ago

Definitely a good idea. Full PWA CLI support will require some more prompts or it can be left to finish later by the user. I will try to find some free time to do this later, unless you would like to do the PR.

northkode commented 5 years ago

Sure, I can put a PR together over the weekend.