Closed FiestaLake closed 8 months ago
I am currently transferring the extension to @slaclau, we are awaiting someone from the gnome team to perform the transfer. Please wait or install manually from github.
Since transferring was taking too long, I uploaded the new version to extensions.gnome.org, I hope it will be available in a few days.
Still not available for me.
I have installed 1.14-rc1 manually to GNOME 45 (Ubuntu 23.10) and I see the following error in the Extension Manager:
Is this something you've seen?
I have installed 1.14-rc1 manually to GNOME 45 (Ubuntu 23.10) and I see the following error in the Extension Manager:
Is this something you've seen?
I have just noticed that https://github.com/arelange/gnome-shell-extension-hibernate-status/issues/110 mentions the same issue I reported above.
@slaclau extension was rejected because of those issues, can you look into them?
Please use a less generic name for the default class you are exporting (for stack trace).
Please remove
Mainloop
imports (line 6 extension.js) and useGLib
instead.Timeout should be removed on disable (line 63 extension.js): https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources
Also remove the source id in disable for
idle_add()
s you are creating in extension.js.
Thanks for sharing the review, I'll try to make these changes one day this week.
I've made the changes and pushed them as v1.14-rc2, @p91paul can you upload to ego please.
@slaclau as of this morning, you are now the owner of the extension on e.g.o.!
While the repository itself contains support GNOME 45, the extension website hasn't been updated to reflect the changes.