arelange / gnome-shell-extension-hibernate-status

Gnome Shell extension that adds a hibernate/hybrid suspend button in Status menu.
GNU General Public License v2.0
151 stars 54 forks source link

GNOME 45 support is not available in gnome extensions website. #109

Closed FiestaLake closed 8 months ago

FiestaLake commented 8 months ago

While the repository itself contains support GNOME 45, the extension website hasn't been updated to reflect the changes.

p91paul commented 8 months ago

I am currently transferring the extension to @slaclau, we are awaiting someone from the gnome team to perform the transfer. Please wait or install manually from github.

p91paul commented 8 months ago

Since transferring was taking too long, I uploaded the new version to extensions.gnome.org, I hope it will be available in a few days.

asfernandes commented 8 months ago

Still not available for me.

lobothiago commented 8 months ago

I have installed 1.14-rc1 manually to GNOME 45 (Ubuntu 23.10) and I see the following error in the Extension Manager:

image

Is this something you've seen?

lobothiago commented 8 months ago

I have installed 1.14-rc1 manually to GNOME 45 (Ubuntu 23.10) and I see the following error in the Extension Manager:

image

Is this something you've seen?

I have just noticed that https://github.com/arelange/gnome-shell-extension-hibernate-status/issues/110 mentions the same issue I reported above.

p91paul commented 8 months ago

@slaclau extension was rejected because of those issues, can you look into them?

  1. Please use a less generic name for the default class you are exporting (for stack trace).

  2. Please remove Mainloop imports (line 6 extension.js) and use GLib instead.

  3. Timeout should be removed on disable (line 63 extension.js): https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources

    Also remove the source id in disable for idle_add()s you are creating in extension.js.

See https://extensions.gnome.org/review/47017

slaclau commented 8 months ago

Thanks for sharing the review, I'll try to make these changes one day this week.

slaclau commented 8 months ago

I've made the changes and pushed them as v1.14-rc2, @p91paul can you upload to ego please.

p91paul commented 8 months ago

@slaclau as of this morning, you are now the owner of the extension on e.g.o.!