search

arelange / gnome-shell-extension-hibernate-status

Gnome Shell extension that adds a hibernate/hybrid suspend button in Status menu.
GNU General Public License v2.0
155 stars 56 forks source link

Add support for Gnome 3.26. #15

Closed franglais125 closed 6 years ago

franglais125 commented 6 years ago

Fix warnings: use 'var' instead of 'let' for functions called from another module.

Example warning on Gnome 3.26:

gnome-shell[2944]: Some code accessed the property 'ConfirmDialog' on the module
'confirmDialog'.  That property was defined with 'let' or 'const' inside the module. This
was previously supported, but is not correct according to the ES6 standard. Any symbols
to be exported from a module must be defined with 'var'. The property access will work
as previously for the time being, but please fix your code anyway.
p91paul commented 6 years ago

Thanks! also for your work on https://github.com/paradoxxxzero/gnome-shell-system-monitor-applet, of which I'm an avid user.

franglais125 commented 6 years ago

Thanks a lot for merging this!

I noticed in the last few days you uploaded some extensions to extensions.gnome.org (hence I thought of this PR), but you did so including supprt for Gnome 3.24.

Gnome 3.26 was released this week, any reason not to add support for this version too?

p91paul commented 6 years ago

Yeah, I was some months late with my maintainership duties, and I hope to perform better in the future.

As for Gnome 3.26, I'm not that proactive on exploring new gnome-shell versions: I usually wait until they hit Arch Linux stable branch, which may take some weeks. On the bright side, Arch is usually the first among the main distros to adopt the latest software, so most people are unaffected if I'm fast enough. I hope this time to not let people wait for months before upload to e.g.o.