search

arelange / gnome-shell-extension-hibernate-status

Gnome Shell extension that adds a hibernate/hybrid suspend button in Status menu.
GNU General Public License v2.0
151 stars 54 forks source link

Adopted to 3.36 gnome #47

Closed tonyzhc closed 4 years ago

tonyzhc commented 4 years ago

I adopted this to the 3.36 gnome look and added two menu items under the power off options; however, I did not implement the alt switch (think they deleted that from the gnome library), and hopefully someone will figure this out as well.

*First time contributing, please let me know if I did anything wrong :)

p91paul commented 4 years ago

Apart from a little bug, it looks fine. However I think it would be better to integrate these 2 actions into the shutdown dropdown (where sleep and shut down are now) instead of outside in the system menu itself. You think it is doable?

Please also edit metadata.json, replacing 3.34 with 3.36 since we are clearly breaking backwards compatibility.

tonyzhc commented 4 years ago

Added those options under the power off tab and changed metadata.json Any more bugs?

p91paul commented 4 years ago

I made a comment, but probably got lost: on line 185 I think you wanted to write this._hybridSleepAction instead of this._hibernateAction, in fact clicking on hibernate put my computer on hybrid sleep instead :)

tonyzhc commented 4 years ago

Oops! Should be fixed now

p91paul commented 4 years ago

Really nice, many thanks for your contribution. This time I really thought it was over.