search

arelange / gnome-shell-extension-hibernate-status

Gnome Shell extension that adds a hibernate/hybrid suspend button in Status menu.
GNU General Public License v2.0
156 stars 58 forks source link

Make the extension work with GNOME 43 #82

Closed pervoj closed 1 year ago

pervoj commented 2 years ago

It would be great to update the extension to integrate with GNOME 43.

p91paul commented 1 year ago

Hi, did you try modifying metadata.json to force the compatibility? just to know if that is enough or there is something not working in the code.

psychonaut commented 1 year ago

I've tried, it didn't work. Menu was reworked in 43.

SukiCZ commented 1 year ago

Hi, Menu disappeared for me too (Gnome 43.0). journalctl /usr/bin/gnome-shell reports one error, not sure if related.

Oct 18 19:56:02 kali gnome-shell[3368]: JS ERROR: Extension hibernate-status@dromi: TypeError: Main.panel.statusArea.aggregateMenu is undefined
                                        enable@~/.local/share/gnome-shell/extensions/hibernate-status@dromi/extension.js:187:9
                                        enable@~/.local/share/gnome-shell/extensions/hibernate-status@dromi/extension.js:243:15
                                        _callExtensionEnable@resource:///org/gnome/shell/ui/extensionSystem.js:184:32
                                        loadExtension@resource:///org/gnome/shell/ui/extensionSystem.js:385:26
                                        _loadExtensions/<@resource:///org/gnome/shell/ui/extensionSystem.js:633:18
                                        collectFromDatadirs@resource:///org/gnome/shell/misc/fileUtils.js:28:28
                                        _loadExtensions@resource:///org/gnome/shell/ui/extensionSystem.js:612:19
                                        _enableAllExtensions@resource:///org/gnome/shell/ui/extensionSystem.js:639:18
                                        _sessionUpdated@resource:///org/gnome/shell/ui/extensionSystem.js:659:14
                                        init@resource:///org/gnome/shell/ui/extensionSystem.js:57:14
                                        _initializeUI@resource:///org/gnome/shell/ui/main.js:309:22
                                        start@resource:///org/gnome/shell/ui/main.js:186:5
                                        @resource:///org/gnome/shell/ui/init.js:6:17
pervoj commented 1 year ago

Hi, Menu disappeared for me too (Gnome 43.0). journalctl /usr/bin/gnome-shell reports one error, not sure if related.

It is related. It means the extension couldn't find the menu into which it was trying to append the items.

saulotoledo commented 1 year ago

PR with the update at https://github.com/arelange/gnome-shell-extension-hibernate-status/pull/84.

p91paul commented 1 year ago

I uploaded the version from @saulotoledo on extensions.gnome.org, I hope review doesn't take too much time!

p91paul commented 1 year ago

New version is now active on e.g.o, review was extremely quick!