search

arelange / gnome-shell-extension-hibernate-status

Gnome Shell extension that adds a hibernate/hybrid suspend button in Status menu.
GNU General Public License v2.0
151 stars 54 forks source link

Add Gnome 43 support #84

Closed saulotoledo closed 1 year ago

saulotoledo commented 1 year ago

Gnome 43 removed aggregateMenu in version 43. So, the extension no longer works on this version unless updated. This PR contains the proper changes to support Gnome 43.

saulotoledo commented 1 year ago

@p91paul, could you help me to check these changes in Gnome 42? I tried not to break the original behavior, but I do not have a setup ready with Gnome 42 to test those changes. Let me know if you have suggestions to improve it as well.

p91paul commented 1 year ago

The reasonable thing to do here is to leave only the Gnome 43 code, and drop all previous versions from metadata.json. extensions.gnome.org will still allow users of previous gnome version to download the lastest compatible version for them, so we are not leaving them out.

saulotoledo commented 1 year ago

Thanks for your feedback, @p91paul. I updated the PR as suggested. I tried to minimize the changes to the original code as well. Let me know if you have any additional suggestions.

p91paul commented 1 year ago

Thanks!!

pervoj commented 1 year ago

@p91paul It would be good to update the screenshot on e.g.o too

p91paul commented 1 year ago

Can someone provide it to me? I understand something changed in 43 but I'm still on 42.

pervoj commented 1 year ago

Can someone provide it to me? I understand something changed in 43 but I'm still on 42.

You can crop it how you need.

Screenshot from 2022-10-23 14-06-51

p91paul commented 1 year ago

New image uploaded!