run_kinematic_perturbation undefined return

[aremazeilles]

From my terminal:

./run_kinematic_perturbation tests/data/input/subject_01_run_01_jointAngles.csv tests/data/input/subject_01_run_01_PlatformData_protocol5.csv test_out
current directory: /home/anthony/code/eurobench/beat_routine
csv file: tests/data/input/subject_01_run_01_jointAngles.csv
platform data: tests/data/input/subject_01_run_01_PlatformData_protocol5.csv
Same sample frequency
ans = 0
warning: kinematic_routine_perturbation: some elements in list of return values are undefined
warning: called from
    kinematic_routine_perturbation at line 90 column 1
    ./run_kinematic_perturbation at line 19 column 7
ROM_p = [](0x0)

An output is generated. Can you check whether you have the same message, and check it? Are you making a return without returning the structure?

[juritaborri]

It should be solved in the branch "protocol_check" please let me know

[aremazeilles]

Thanks I should jave looked at this before Thursday midday

[aremazeilles]

nop, this remains the same

The input files are the good ones. I think it is because in the main script you expect some return value:

[ROM_p]=kinematic_routine_perturbation(arg_list{1}, arg_list{2}, arg_list{3})

But function kinematic_routine_perturbation does not place any values within ROM_p.

I would actually change this to return like a boolean, whether the operation succeeds. But in any case, I think the current code does not do what is written (no output), so the code should be adjusted, in my opinion

[aremazeilles]

By no output, I mean it is written:

% OUTPUT: % - ROM_p is the ROM value along each direction of the perturbation. Dimension 9xNa. First row: angle labes, From second to 8th row ROMp values, with each row related to one perturbation direction following the fixed sequence: North, North-East, East, South-East, South, South-West, West, North-West.

When the function does not written anything (result stored in file)

[juritaborri]

Did you encounter this problem only in kinematic_perturbation? It seems strange beacause all routine have been written with the same logic of the return, I do not understand why in the other you do not have this message.

What is your suggestion? To write some string in the ROM_p like "No computed" when the protocol is wrong?

[aremazeilles]

Function kinematic_routine_perturbation has the following signature:

function [ROM_p]=kinematic_routine_perturbation(fileName,PlatformData, outFolder)

So we expect the function to return ROM_p. But that variable is not handled in the script.

When you call that function in the main program:

[ROM_p]=kinematic_routine_perturbation(arg_list{1}, arg_list{2}, arg_list{3})

we expect thhat function will return something, to be placed in ROM_P. As it is not done, the system argues with the message mentioned: some elements in list of return values are undefined

My suggestion to solve it would be to state that kinematic_routine_perturbation returns a success parameter (i.e a boolean), and in the function set that boolean to true or false depending on the operation could be performed.

Does it make sense to you?

[juritaborri]

I have found a mistake on the function, I have added the ROM_p as an output (before I wrote only ROM in the code). I have committed this change on the master. Let me know if it is now ok.

Juri

Il giorno lun 6 lug 2020 alle ore 16:43 Anthony Remazeilles < notifications@github.com> ha scritto:

Function kinematic_routine_perturbation https://github.com/aremazeilles/beat_routine/blob/master/beat/Functions/kinematic_routine_perturbation.m#L1 has the following signature:

function [ROM_p]=kinematic_routine_perturbation(fileName,PlatformData, outFolder)

So we expect the function to return ROM_p. But that variable is not handled in the script.

When you call that function in the main program https://github.com/aremazeilles/beat_routine/blob/master/run_kinematic_perturbation#L19 :

[ROM_p]=kinematic_routine_perturbation(arg_list{1}, arg_list{2}, arg_list{3})

we expect thhat function will return something, to be placed in ROM_P. As it is not done, the system argues with the message mentioned: some elements in list of return values are undefined

My suggestion to solve it would be to state that kinematic_routine_perturbation returns a success parameter (i.e a boolean), and in the function set that boolean to true or false depending on the operation could be performed.

Does it make sense to you?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/aremazeilles/beat_routine/issues/11#issuecomment-654281690, or unsubscribe https://github.com/notifications/unsubscribe-auth/APD2ILKO7FOECAUKXZ332LLR2HPKHANCNFSM4M3EZ5BA .

--

Juri TABORRI, PhD Research Fellow juri.taborri@unitus.it juri.taborri@uniroma1.it ’La Tuscia', University of Viterbo Department of Economics, Engineering. Society and Business Organization (DEIM) Largo dell'Università 01100, Viterbo ITALY +39 0761357049 <+39%200761%20357049>

[aremazeilles]

ok, I´ll check it when I find time. Well no, I don´t see that change. Did you push your commit?

[juritaborri]

Hi Anthony, I do not know why the push has been rejected. This is the correct file, can you add it?

Thanks Juri

Il giorno mer 8 lug 2020 alle ore 15:53 Anthony Remazeilles < notifications@github.com> ha scritto:

ok, I´ll check it when I find time. Well no, I don´t see that change. Did you push your commit?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/aremazeilles/beat_routine/issues/11#issuecomment-655534675, or unsubscribe https://github.com/notifications/unsubscribe-auth/APD2ILJ35HAUDIVNOIJWSXLR2R243ANCNFSM4M3EZ5BA .

--

Juri TABORRI, PhD Research Fellow juri.taborri@unitus.it juri.taborri@uniroma1.it ’La Tuscia', University of Viterbo Department of Economics, Engineering. Society and Business Organization (DEIM) Largo dell'Università 01100, Viterbo ITALY +39 0761357049 <+39%200761%20357049>

[aremazeilles]

Maybe the puh was rejected because your branch was not up to date. Did you try to make a pull before? I actually added some more CI files last week. So the process would be to pull, then to push.

You cannot push on a branch if that branch has commits you do not have in yours.

[juritaborri]

Yes, I did all these steps. I have tried to do again this operation this morning but I think there is a general problem with the git server because I am not able to open any repository. As soon, I will try again

Il giorno lun 13 lug 2020 alle ore 08:33 Anthony Remazeilles < notifications@github.com> ha scritto:

Maybe the puh was rejected because your branch was not up to date. Did you try to make a pull before? I actually added some more CI files last week. So the process would be to pull, then to push.

You cannot push on a branch if that branch has commits you do not have in yours.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/aremazeilles/beat_routine/issues/11#issuecomment-657386110, or unsubscribe https://github.com/notifications/unsubscribe-auth/APD2ILKTD2G6DL7P2RIS7ZTR3KTB5ANCNFSM4M3EZ5BA .

--

Juri TABORRI, PhD Research Fellow juri.taborri@unitus.it juri.taborri@uniroma1.it ’La Tuscia', University of Viterbo Department of Economics, Engineering. Society and Business Organization (DEIM) Largo dell'Università 01100, Viterbo ITALY +39 0761357049 <+39%200761%20357049>

[juritaborri]

I should have solved the issue. I actually see the right version of the kinematic_perturbation routine both on my local repository and online. Can you confirm me?

Il giorno lun 13 lug 2020 alle ore 09:07 juri taborri < juri.taborri@unitus.it> ha scritto:

Yes, I did all these steps. I have tried to do again this operation this morning but I think there is a general problem with the git server because I am not able to open any repository. As soon, I will try again

Il giorno lun 13 lug 2020 alle ore 08:33 Anthony Remazeilles < notifications@github.com> ha scritto:

Maybe the puh was rejected because your branch was not up to date. Did you try to make a pull before? I actually added some more CI files last week. So the process would be to pull, then to push.

You cannot push on a branch if that branch has commits you do not have in yours.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/aremazeilles/beat_routine/issues/11#issuecomment-657386110, or unsubscribe https://github.com/notifications/unsubscribe-auth/APD2ILKTD2G6DL7P2RIS7ZTR3KTB5ANCNFSM4M3EZ5BA .

--

Juri TABORRI, PhD Research Fellow juri.taborri@unitus.it juri.taborri@uniroma1.it ’La Tuscia', University of Viterbo Department of Economics, Engineering. Society and Business Organization (DEIM) Largo dell'Università 01100, Viterbo ITALY +39 0761357049 <+39%200761%20357049>

--

Juri TABORRI, PhD Research Fellow juri.taborri@unitus.it juri.taborri@uniroma1.it ’La Tuscia', University of Viterbo Department of Economics, Engineering. Society and Business Organization (DEIM) Largo dell'Università 01100, Viterbo ITALY +39 0761357049 <+39%200761%20357049>

[aremazeilles]

Yes, this seems to be solved now. Did not check if similar adjustment may be needed in other scripts.

[aremazeilles]

Similar adjustment might be needed for PL_p and EA_p in posturographic_routine_perturbation.m and posturographic_routine_unperturbed, G and phi in sinusoidal_perturbation.m, and for the parameters used in step_perturbation.m

[juritaborri]

I will check it within tomorrow and inform you Thanks Juri

Il giorno lun 3 ago 2020 alle ore 13:44 Anthony Remazeilles < notifications@github.com> ha scritto:

Similar adjustment might be needed for PL_p and EA_p in posturographic_routine_perturbation.m and posturographic_routine_unperturbed, G and phi in sinusoidal_perturbation.m, and for the parameters used in step_perturbation.m

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/aremazeilles/beat_routine/issues/11#issuecomment-667976107, or unsubscribe https://github.com/notifications/unsubscribe-auth/APD2ILLWKEYIOWDY22N3TZTR62PIHANCNFSM4M3EZ5BA .

--

Juri TABORRI, PhD Research Fellow juri.taborri@unitus.it juri.taborri@uniroma1.it ’La Tuscia', University of Viterbo Department of Economics, Engineering. Society and Business Organization (DEIM) Largo dell'Università 01100, Viterbo ITALY +39 0761357049 <+39%200761%20357049>

[juritaborri]

Hi Anthony, I have modified the output name in each function; however I have an issue that I am not able to solde on GIT GUI on my local PC (as in the attachment). I am not able to committ and push the modifications. Do you have an idea about this error? In the meanwhile, Please find in the attachment the modified functions.

Thank you Juri

Il giorno lun 3 ago 2020 alle ore 13:47 juri taborri juri.taborri@unitus.it ha scritto:

I will check it within tomorrow and inform you Thanks Juri

Il giorno lun 3 ago 2020 alle ore 13:44 Anthony Remazeilles < notifications@github.com> ha scritto:

Similar adjustment might be needed for PL_p and EA_p in posturographic_routine_perturbation.m and posturographic_routine_unperturbed, G and phi in sinusoidal_perturbation.m, and for the parameters used in step_perturbation.m

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/aremazeilles/beat_routine/issues/11#issuecomment-667976107, or unsubscribe https://github.com/notifications/unsubscribe-auth/APD2ILLWKEYIOWDY22N3TZTR62PIHANCNFSM4M3EZ5BA .

--

Juri TABORRI, PhD Research Fellow juri.taborri@unitus.it juri.taborri@uniroma1.it ’La Tuscia', University of Viterbo Department of Economics, Engineering. Society and Business Organization (DEIM) Largo dell'Università 01100, Viterbo ITALY +39 0761357049 <+39%200761%20357049>

--

Juri TABORRI, PhD Research Fellow juri.taborri@unitus.it juri.taborri@uniroma1.it ’La Tuscia', University of Viterbo Department of Economics, Engineering. Society and Business Organization (DEIM) Largo dell'Università 01100, Viterbo ITALY +39 0761357049 <+39%200761%20357049>

[aremazeilles]

Hi Juri.

however I have an issue that I am not able to solde on GIT GUI on my local PC (as in the attachment)

I cannot see any attached image. Can you share it again, or send it to me through direct email?

[aremazeilles]

OK, the message is thus: unmmerged files cannot be committed. file kinematic_routine_perturbation.m has merge conflicts. You must resolve them and stage the file before committing.

This happens when a file has been changed by someone on the remote server, but also by you locally in a commit. When you pull, i.e bring the remote commit to your local repo, git is not able to merge by itself the file as changes seems to happen at very near places.

So you have to open the file kinematic_routine_perturbation.m, check the content of it. In the conflict lies, you should see indication like the one indicated here on step 4. You have to select the good version, remove the other, and remove the symbols indicating the conflict site.

Once done, you have to proceed to the step 5 from the previous link: stage the file (git add), and then do commit.

If you do not see how to do it, we can have a quick skype to do it together.

[aremazeilles]

OK, I saw your email, and I see that you just modified some files. I'll check it in the morning and gt back to you to confirm that this is solved.

Thanks

[aremazeilles]

Seems the issue is not hapening anymore