search

aremazeilles / beat_routine

Performance Indicators developed by BEAT consortium for the Eurobench project
0 stars 2 forks source link

organize per protocol #14

Closed aremazeilles closed 4 years ago

aremazeilles commented 4 years ago

I would propose to reorganize the input data and the readme per protocol. Actually, we need to know for the automation which algorithm to lunch depending on the protocol used.

I can handle that

Could you tell me, for each o the 7 protocol the script to launch? I have seen from the README that some script are specific to some given protocol, but I would like to have the relation the other way round: per protocol the list of scripts to launch

juritaborri commented 4 years ago

Is it ok or Do you prefer I open a new branch?

Protocols and related scripts.pdf

aremazeilles commented 4 years ago

Thanks for this clear document. I will propose you some changes, and if you agree I will then create the branch to implement the proposed changes.

juritaborri commented 4 years ago

It's ok!

aremazeilles commented 4 years ago

My vision here is that an experiment conducted has been following a protocol. So when we are about to score it, the first key is "which protocol have you been following?".

In that sense, I would suggest as entry_points:

Then, internally, each of the entry point will successively call the appropriate metrics, as you suggest in your pdf files.

Does it make sense to you ? This is just about the logic, I will propose the code to do so later

juritaborri commented 4 years ago

I agree with this point of view

aremazeilles commented 4 years ago

OK great, I will suggets some changes to move towards that direction then

juritaborri commented 4 years ago

I would like to highlight just one aspect before you will suggest the changes. We have to consider this possibility: protocol 1 can be carried out also without using EMG (maybe the user is not interested in the evaluation of the muscle activity), if in the run_protocol1 we automatize the run of all possible routines related to protocol1, we may encounter in error if the EMG file does not exist.

Il giorno mar 12 mag 2020 alle ore 11:56 Anthony Remazeilles < notifications@github.com> ha scritto:

OK great, I will suggets some changes to move towards that direction then

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/aremazeilles/beat_routine/issues/14#issuecomment-627239055, or unsubscribe https://github.com/notifications/unsubscribe-auth/APD2ILJYRS4O7T6LUTO2KFLRREMNVANCNFSM4M3FWFJA .

--

Juri TABORRI, PhD Research Fellow juri.taborri@unitus.it juri.taborri@uniroma1.it ’La Tuscia', University of Viterbo Department of Economics, Engineering. Society and Business Organization (DEIM) Largo dell'Università 01100, Viterbo ITALY +39 0761357049 <+39%200761%20357049>

aremazeilles commented 4 years ago

Good point, we still have to see how to handle such type of situation, but I would assume for now that all needed input is available.

ping @alfonsotecnalia : this is about a protocol computing various metrics, and that we could consider that some metrics may not be computed if the needed information is not provided. In the concrete case, a protocol can compute emg related stuff, but if emg is not measured,w e could stil compute other metrics. Is this correct @juritaborri ?

juritaborri commented 4 years ago

Maybe a possible solution could be:

  1. Check the available files with an if loop
  2. Run all the possible routines based on the available files

Il giorno mar 12 mag 2020 alle ore 16:49 Anthony Remazeilles < notifications@github.com> ha scritto:

Good point, we still have to see how to handle such type of situation, but I would assume for now that all needed input is available.

ping @alfonsotecnalia https://github.com/alfonsotecnalia : this is about a protocol computing various metrics, and that we could consider that some metrics may not be computed if the needed information is not provided. In the concrete case, a protocol can compute emg related stuff, but if emg is not measured,w e could stil compute other metrics. Is this correct @juritaborri https://github.com/juritaborri ?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/aremazeilles/beat_routine/issues/14#issuecomment-627393651, or unsubscribe https://github.com/notifications/unsubscribe-auth/APD2ILNCGJBDV7F5Y4DWEHDRRFOZBANCNFSM4M3FWFJA .

--

Juri TABORRI, PhD Research Fellow juri.taborri@unitus.it juri.taborri@uniroma1.it ’La Tuscia', University of Viterbo Department of Economics, Engineering. Society and Business Organization (DEIM) Largo dell'Università 01100, Viterbo ITALY +39 0761357049 <+39%200761%20357049>