aremazeilles / beat_routine

Performance Indicators developed by BEAT consortium for the Eurobench project
0 stars 2 forks source link

kinematicwalking #8

Closed aremazeilles closed 4 years ago

aremazeilles commented 4 years ago

Hi @juritaborri

You can look at the changes done with the button file changed. Please have a look at the changes proposed.

If you have question, we can discuss. If not, Press "Merge pull request" button. That will bring it to the master branch.

I would then ask you to perform similar operation on the other scripts. But we can chat on it If you prefer me to help (like for moving the file and so on in the git repo), just tell me.

juritaborri commented 4 years ago

OK! I will check all the canges and then come back to you. I also would try to make similar changes in other scripts to verify if I am able to use in the right way the git.

aremazeilles commented 4 years ago

If needed, we can make a short phone call to explain some aspects, if needed

juritaborri commented 4 years ago

I have adjusted all the other functions based on your suggestions provided for kinematicwalking. I have also updated the format of some outputs and the readme file.

aremazeilles commented 4 years ago

Ok, thanks. I´ll have a look at it along the week.

aremazeilles commented 4 years ago

Are you trying the files under octave on your machine? Perhaps this is because you use it from the gUI, so that what is loaded remain loaded somehow, but none of them worked to me. I had to add the pkg load in each of the run_ files

aremazeilles commented 4 years ago

I will merge this, and open some issues for other aspects.

You should swith to the master branch, and make fetch / merge Then, if you want to solve an issue, create a branch (one issue per branch), and commit there. From time to time, push it to a new remote branch.

Is that ok with you?

juritaborri commented 4 years ago

Are you trying the files under octave on your machine? Perhaps this is because you use it from the gUI, so that what is loaded remain loaded somehow, but none of them worked to me. I had to add the pkg load in each of the run_ files

Yes.. I run them always with OCtave GUI. How can I solve this issue?

aremazeilles commented 4 years ago

I solved the issue, by adding in each run file the load of the io and signal packages