aremazeilles / eurobench_documentation

Description of some Eurobench Benchmarking Software mechanisms
5 stars 3 forks source link

New data formats #18

Closed SjoerdBruijn closed 4 years ago

SjoerdBruijn commented 4 years ago

For some of the code we are working on, we require; Full body CoM trajectory (nx3, with n being number of samples) Full body angular momentum (calculated around CoM) (nx3, with n being number of samples) Combined inertia of the body (inertia tensor of all segments combined) (nx3x3 with n being number of samples)

can these be added as data format somehow? We think that CSV files may work.

aremazeilles commented 4 years ago

adding colleagues to the discussion: ping @flxalr @davidpintofernandez @alfonsotecnalia.

Could you confirm for each of the required format the related header? For the COM for instance I expect it to be timestampt; X; Y, Z correct? Could you suggest structure for the two following ones?

SjoerdBruijn commented 4 years ago

CoM: timestampt, X, Y, Z AngMom: timestampt, X, Y, Z FullBodyI: timestampt, Xx, Xy, Xz, Yx, Yy, Yz, Zx, Zy, Zz another important thing (that I realise just now) to agree on would be what the different global axes directions are; for instance, we always use X as AP axis (pointing forward, in gait direction), Y pointing left, and Z up. The actual definition is of course arbitrary, but I think it's good to have a standard that says what the data should look like. It seems that this is not in place yet in the description? (or did I miss this? )

m-lancini commented 4 years ago

We usually have the X as AP axis and Y as the vertical axis (since many gait analysis models do not require the Z axis). I think it would be best to employ existing standards, such as the one of the International Society of Biomechanics: see https://www.ncbi.nlm.nih.gov/pubmed/8550644 ISB recommendations for standardization in the reporting of kinematic data.

SjoerdBruijn commented 4 years ago

I'm OK with any definition, but I think that one should be defined. The reason we use z as up is because it facilitates plotting in matlab, where the Z is also up in 3d figures. As said, it doesnt matter, but it matters because we shouldn't be using different definitions. I agree that the ISB definitions may be a smart way to go.

m-lancini commented 4 years ago

Completely agree, we should define the standard somewhere, for the global reference and for the bodies relative references as well.

DavidPintoFernandez commented 4 years ago

I completely agree that we have to define a standard, and also agree that the best solution is to adapt to what is already done and well extended, the ISB recommendations, as Matteo suggested.

aremazeilles commented 4 years ago

How would you like to define that standard? Can somebody do it ? Or just pass me an example text, and I can start incorporate it?

aremazeilles commented 4 years ago

Apart from that axis direction, is that ok with you @DavidPintoFernandez to insert these other format?

If yes, I can work on it.

flxalr commented 4 years ago

Are we only talking about the three mentioned files (CoM, AngMom, FullBodyI)? I think that a conversion to a global reference frame is feasible.

Some questions for better understanding: Do you record human motion plus exo-motion or just the motion of the human subject? Will the exo be considered in the computation of the CoM, angular momentum and full body inertia? Defining one reference frame for everything will get problematic if you want to export data based on the underlying model of the exo (or humanoid).

SjoerdBruijn commented 4 years ago

yes, we are only talking about CoM, angmom, and FullbodyI and these should all be expressed in a global frame. So far, we have done mostly human only testing. However, when doing human+exo, the properties of the exo need to be taken into account.

aremazeilles commented 4 years ago

Resuming discussion to move forward

I think it would be best to employ existing standards, such as the one of the International Society of Biomechanics: see https://www.ncbi.nlm.nih.gov/pubmed/8550644 Do you refer to Figure 1 axis direction on that paper?

With respect to the 3 proposed types, CoM, AngMom, FullBodyI, should we add a short description sentence? So far we only have the one line description provided by Sjoerd:

  • Full body CoM trajectory (nx3, with n being number of samples)
  • Full body angular momentum (calculated around CoM) (nx3, with n being number of samples)
  • Combined inertia of the body (inertia tensor of all segments combined) (nx3x3 with n being number of samples)
m-lancini commented 4 years ago

I think it would be best to employ existing standards, such as the one of the International Society of Biomechanics: see https://www.ncbi.nlm.nih.gov/pubmed/8550644 Do you refer to Figure 1 axis direction [on that paper (https://www.ece.uvic.ca/~bctill/papers/mocap/Wu_Cavanagh_1995.pdf)?

With respect to the 3 proposed types, CoM, AngMom, FullBodyI, should we add a short description sentence? So far we only have the one line description provided by Sjoerd:

Yes, I'd go with that.. and I'd use the same standards to describe local relative references (the arm's the leg's... etc)

aremazeilles commented 4 years ago

@SjoerdBruijn and other, could you have a look at the proposition in branch udbenchmark, where I introduce the 3 formats?

I did put a reference for the 2 first one, could you check if you have more relevant references, and propose one for the inertia tensor?

Then I did not mention the axis direction. Should I do it in one of these format, or provide at the beginning of the section a general spec ?

@SjoerdBruijn can you confirm you update the inertia tensor at a given frequency?

nickkluft commented 4 years ago

The proposed formats seem to fit the udbenchmark project. For sake of consistency, it might be wise to use similar metric units (e.g. milliseconds instead of sec, and mm instead of m) in the proposed formats, and have the estimates in the global frame of reference.

Regarding references, I would suggest to refer to Kinetics of Human Motion By Vladimir M. Zatsiorsky.

m-lancini commented 4 years ago

I'd like to use seconds (s) and meters (m) instead of ms and mm since when adding also newtons (N) the idea of having a mN just to be consistent is confusing. But the important thing is to be explicit in that. Concerning Kinetics of Human Motion I see it uses a different reference for the Y axis, please make sure that the reference system is rotated according to the ISB standard.

aremazeilles commented 4 years ago

I would also be in favour of seconds and meters. I created an issue to adjust other format.

Sjoerd mentioned earlier that the ISB recommandation would be ok for your protocol. I hope this is right.

I could mention it at the beginning of the data format section, with something like:

For any measurement involving a global reference frame, we consider this frame to be as proposed in the ISB recommandations :

aremazeilles commented 4 years ago

I added at the begining of the document a subsection on the default global reference frame.

Ready to be merged ?