Potential null pointer dereference in sirfilecache.c:394-395 (branch: syslog)

[johnsonjh]

            if (!_sir_bittest(sf->opts, SIRO_NOHDR))
                _sirfile_writeheader(sf, SIR_FHBEGIN);

• sf might be null.

[aremmell]

if (_sirfile_validate(sf)) {
     sfc->files[sfc->count++] = sf;

     if (!_sir_bittest(sf->opts, SIRO_NOHDR))
          _sirfile_writeheader(sf, SIR_FHBEGIN);

Actualy, that _sirfile_validate checks sf... must be a false positive.

[johnsonjh]

I'll run it with another tool just to see what it says, but possibly so.

[aremmell]

I'm 100% sure:

bool _sirfile_validate(sirfile* sf) {
    return _sir_validptrnofail(sf) && _sir_validptrnofail(sf->f) &&
           _sir_validstrnofail(sf->path) && _sir_validfd(sf->id);
}