search

arempe93 / bunny-mock

A mock client for RabbitMQ modeled after the Bunny client in ruby
http://www.rubydoc.info/github/arempe93/bunny-mock
MIT License
44 stars 37 forks source link

Fixed error for bunny 2.6.x that requires stdlib/timeout to be loaded #28

Closed pangdudu closed 7 years ago

pangdudu commented 7 years ago

I've testing with bunny-mock 1.5 and bunny 2.6.3, when loading the bunny/exception class it fails unless you:

require 'timeout'

beforehand.

cheers

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling d1ff04bdc5fadca30f65b0d324fefb91ff9fee4a on pangdudu:fix/timeout_load_error_for_bunny_2.6.x into 09b5cb735f26c87d63664816d46247767e914b94 on arempe93:master.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling d1ff04bdc5fadca30f65b0d324fefb91ff9fee4a on pangdudu:fix/timeout_load_error_for_bunny_2.6.x into 09b5cb735f26c87d63664816d46247767e914b94 on arempe93:master.

arempe93 commented 7 years ago

hey @pangdudu - thanks for fixing this problem! only one comment - is there any reason to update the gemspec to >= 2.6? I think some people are still using older versions of bunny and I don't want to force them to upgrade. The change should work on older versions of bunny too

arempe93 commented 7 years ago

Fixed via 606172e with help from @dwhenry - thanks for your contribution!