Implement reject functionality

arempe93 / bunny-mock

A mock client for RabbitMQ modeled after the Bunny client in ruby

http://www.rubydoc.info/github/arempe93/bunny-mock

MIT License

44 stars 37 forks source link

Implement reject functionality #32

Closed binaryberry closed 7 years ago

binaryberry commented 7 years ago

This leverages the acknowledgement_state accessor that was added to support ack/nack tracking. This supports the requeue param.

Paired with @dwhenry

coveralls commented 7 years ago

Coverage remained the same at 100.0% when pulling f5ffb9d1a7794064dcc4a170292baf92cf89e93e on alphagov:add-tracking-for-channel-reject-method into 4f61a5e106e5e16098bb90b03e15ecc075de613c on arempe93:master.

arempe93 commented 7 years ago

thanks for the PR - ill try to look at this after work

binaryberry commented 7 years ago

Hi @arempe93, not sure if you got a chance to look at this yet? Do let us know if there is anything unclear.

arempe93 commented 7 years ago

@binaryberry hey sorry I took a long weekend and forgot to look beforehand.

arempe93 commented 7 years ago

Everything looks good so I'll do a 1.7.0 release sometime today

binaryberry commented 7 years ago

@arempe93 Thanks a lot! 😃

binaryberry commented 7 years ago

Hi @arempe93 ! I wanted to check in to see if you might know when you'd be releasing this? It'll be helpful for us knowing we're no longer relying on our own fork, but I do realise you're doing this in your own time.

arempe93 commented 7 years ago

@binaryberry just pushed out v1.7.0 - thanks for your patience and for reminding me

binaryberry commented 7 years ago

@arempe93 Thank you so much for doing this! 🎉