search

arena21 / idps

Automatically exported from code.google.com/p/idps
0 stars 0 forks source link

Envenom modified by Envenom uptime #48

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
See http://elitistjerks.com/f78/t86497-
java_app_modelling_rogue_dps_updated_3_3_3_a/p10/#post1615102

What is the expected output? What do you see instead?
Due to proc chance on Envenom, theorycraft suggests a fast dagger with Deadly 
Poison in the 
mainhand outperforms a slow dagger with Instant Poison in the mainhand assuming 
the two 
daggers have equal DPS.

What version of the product are you using? On what operating system?
r97 on OSX

Please provide any additional information below.

Original issue reported on code.google.com by jesperma...@gmail.com on 11 Apr 2010 at 9:40

GoogleCodeExporter commented 8 years ago 
I was aware of this, however i left it out for code simplicity. I will change 
it but it will have minimal impact on 
dps calculations.

Original comment by ch...@clan-fwd.com on 12 Apr 2010 at 12:02

GoogleCodeExporter commented 8 years ago 
[deleted comment]
GoogleCodeExporter commented 8 years ago 
Cool. I intentionally mentioned your previous reply to the issue in the top of 
my post on EJ to give an idear of 
the magnitude of the problem. Anyway good to know you'll take the time to fix 
it - consistency between 
models is always nice:)

While we're at it you may want to take a look at my edit3 on EJ:
Consider wip.getSpeed()/1.4F*(0.2F+0.02F*talents.getTalentPoints("IPoisons")) 
in the ipProcChance. Again, I 
may be missing something, but why is the frequency only increased with 2% per 
point in Improved Poisons 
and not 10% per point as per the tooltip?

Best regards

Original comment by jesperma...@gmail.com on 12 Apr 2010 at 1:55

GoogleCodeExporter commented 8 years ago 
It's because

wip.getSpeed()/1.4F * (0.2F+0.02F*talents.getTalentPoints("IPoisons"))

is the same as

wip.getSpeed()/1.4F * 0.2F * 0.1F*talents.getTalentPoints("IPoisons")

while the second version reads more like the talent discription.

Original comment by ch...@clan-fwd.com on 12 Apr 2010 at 2:50

GoogleCodeExporter commented 8 years ago 
2nd formula should be

wip.getSpeed()/1.4F * 0.2F * (1+0.1F*talents.getTalentPoints("IPoisons"))

sorry :)

Original comment by ch...@clan-fwd.com on 12 Apr 2010 at 3:21

GoogleCodeExporter commented 8 years ago

Original comment by ch...@clan-fwd.com on 6 May 2010 at 12:22