search

arenadata / gpdb

Arenadata DB
https://docs.arenadata.io/en/ADB/current/introduction/intro.html
Apache License 2.0
40 stars 22 forks source link

Remove redundant extern keywords #1050

Closed Ildangbaek closed 20 hours ago

Ildangbaek commented 1 month ago

Remove redundant extern keywords

It is written in the "6.2.2 Linkages of identifiers" chapter of C99 standard (https://www.open-std.org/jtc1/sc22/wg14/www/docs/n1256.pdf): "If the declaration of an identifier for a function has no storage-class specifier, its linkage is determined exactly as if it were declared with the storage-class specifier extern". The "6.9 External definitions" chapter contains the following: "An external definition is an external declaration that is also a definition of a function (other than an inline definition) or an object". So the extern keyword is redundant in function definitions.

Greenplum specific code is changed only.

andr-sokolov commented 1 month ago

bender build

BenderArenadata commented 1 month ago

Failed job Build ubuntu22 for x86_64: https://gitlab.adsw.io/arenadata/github_mirroring/gpdb/-/jobs/1909895

BenderArenadata commented 1 month ago

Allure report https://allure.adsw.io/launch/80214

BenderArenadata commented 1 month ago

Failed job Orca unittests on x86_64: https://gitlab.adsw.io/arenadata/github_mirroring/gpdb/-/jobs/1909900

BenderArenadata commented 1 month ago

Failed job Regression tests with ORCA on x86_64: https://gitlab.adsw.io/arenadata/github_mirroring/gpdb/-/jobs/1909899

BenderArenadata commented 1 month ago

Failed job Regression tests with Postgres on x86_64: https://gitlab.adsw.io/arenadata/github_mirroring/gpdb/-/jobs/1909898

BenderArenadata commented 1 month ago

Failed job Resource group isolation tests on x86_64: https://gitlab.adsw.io/arenadata/github_mirroring/gpdb/-/jobs/1909902

BenderArenadata commented 1 month ago

Failed job Behave tests on x86_64: https://gitlab.adsw.io/arenadata/github_mirroring/gpdb/-/jobs/1909901

andr-sokolov commented 1 month ago

Are there any more redundant extern keywords? Add please PR description about why extern is redundant in this case

Ildangbaek commented 3 weeks ago

Are there any more redundant extern keywords? Add please PR description about why extern is redundant in this case

Done.

andr-sokolov commented 3 weeks ago

bender build

BenderArenadata commented 3 weeks ago

Allure report https://allure.adsw.io/launch/82288

andr-sokolov commented 1 day ago

bender build

BenderArenadata commented 23 hours ago

Allure report https://allure.adsw.io/launch/84224