search

arenadata / gpdb

Arenadata DB
https://docs.arenadata.io/en/ADB/current/introduction/intro.html
Apache License 2.0
40 stars 22 forks source link

ADBDEV-6139 Fix clang compiler errors #1056

Closed dnskvlnk closed 2 weeks ago

dnskvlnk commented 1 month ago

Fix clang compiler errors

This patch fixes multiple errors produced by clang:

  1. -Wimplicit-fallthrough was fixed by adding generic macro
  2. -Wunused-function
  3. -Wunused-variable and -Wunused-but-set-variable
  4. -Wvla-cxx-extension
  5. Unknown "asm" keyword
  6. -Wdeprecated-declarations in third party headers was fixed by disabling this error for particular headers

Also, this patch adds an ability to build gpdb in a docker container using clang

andr-sokolov commented 2 weeks ago

What about creating a new dockerfile for clang? We need to check compilation only. It's redundant to run make install and mocking tests two times.

andr-sokolov commented 2 weeks ago

The fix will be split into several PRs