search

arenadata / gpdb

Arenadata DB
https://docs.arenadata.io/en/ADB/current/introduction/intro.html
Apache License 2.0
40 stars 22 forks source link

ADBDEV-6344: Fix gpperfmon recording plpgsql queries with SPI cursors #1060

Closed silent-observer closed 3 weeks ago

silent-observer commented 1 month ago

Fix gpperfmon recording plpgsql queries with SPI cursors

Before this patch gpperfmon recorded plpgsql queries that used cursors (for example FOR loops) even with log_min_messages < DEBUG 4. Logging for all the other queries in plpgsql has been already disabled before by cc2446b9333c52932c7a4ceeb522966d9cce31c3, this patch fixes the same issue for SPI cursors. Logging is enabled only for log_min_messages equal to DEBUG 5 or DEBUG 4.

BenderArenadata commented 1 month ago

Allure report https://allure.adsw.io/launch/81108

BenderArenadata commented 1 month ago

Allure report https://allure.adsw.io/launch/81161

BenderArenadata commented 1 month ago

Allure report https://allure.adsw.io/launch/81174

BenderArenadata commented 1 month ago

Failed job Behave tests on x86_64: https://gitlab.adsw.io/arenadata/github_mirroring/gpdb/-/jobs/2004009

BenderArenadata commented 1 month ago

Allure report https://allure.adsw.io/launch/81285

BenderArenadata commented 1 month ago

Allure report https://allure.adsw.io/launch/81555

RekGRpth commented 1 month ago

What is the original purpose of this patch and the previous patch? After all, SPI can be used without PL-languages, of which there are also several, and not just one plpgsql.

Stolb27 commented 3 weeks ago

Closed in favor of #1063