search

arenanet / api-cdi

Collaborative Development Initiative for Public APIs
253 stars 41 forks source link

/v2/quaggans does not return X-Result-Total #15

Closed sliekens closed 9 years ago

sliekens commented 9 years ago

Example request: https://api.guildwars2.com/v2/quaggans?ids=summer,vacation

Actual response headers

HTTP/1.1 200 OK Content-Type: application/json; charset=utf-8 Content-Encoding: gzip Content-Language: en Vary: Accept-Encoding Server: Microsoft-IIS/7.5 X-Result-Count: 2 Access-Control-Allow-Origin: * X-Content-Type-Options: nosniff Date: Tue, 03 Mar 2015 19:12:37 GMT Content-Length: 107

Expected response headers

HTTP/1.1 200 OK ... X-Result-Count: 2 X-Result-Total: 35

lye commented 9 years ago

X-Page-Total, X-Page-Size and X-Result-Total are only returned when paginating the results, e.g. https://api.guildwars2.com/v2/quaggans?page=0. This should be true for all bulk-expanded endpoints, not just /v2/quaggans.

sliekens commented 9 years ago

Is that how it's always been? I'm pretty sure that I remember there being a Total header for bulk requests.

lye commented 9 years ago

I may have broken things a couple of weeks ago. Now that I've had some coffee, it makes sense that X-Result-Total would be sent with all bulk-expanded responses.

lye commented 9 years ago

The fix for this is now deployed (whoo!)