arenanet / api-cdi

Collaborative Development Initiative for Public APIs
253 stars 41 forks source link

Scribe recipes with missing items from ingredients #174

Closed BryghtShadow closed 8 years ago

BryghtShadow commented 8 years ago

There are scribe recipes that are built using items in guild storage (namely banners and decorations). However, these items are missing from the ingredients array.

https://api.guildwars2.com/v2/recipes/10183

{
  "type": "GuildDecoration",
  "output_item_id": 71716,
  "output_item_count": 1,
  "min_rating": 125,
  "time_to_craft_ms": 1000,
  "disciplines": [ "Scribe" ],
  "flags": [ "AutoLearned" ],
  "ingredients": [
    { "item_id": 70454, "count": 1 },
    { "item_id": 75087, "count": 1 },
    { "item_id": 19713, "count": 5 }
  ],
  "id": 10183,
  "chat_link": "[&CccnAAA=]"
}

Ingredients should be:

lye commented 8 years ago

EDIT: Derp, not the whitelist.

Yeah, scribe recipes are a bit different -- I presume the ingredient lists are stored somewhere else in content.

Would it make sense to put the bits pulled from guild storage in the ingredients array? If so, should they be flagged somehow as "takes from guild storage"? Also should probably put a flag in there to indicate whether or not the output_item_id goes into guild storage or not.

BryghtShadow commented 8 years ago

Does the guild storage use a different item_id compared to the output_item_id in recipes? (I wish I could link items in the guild storage)

lye commented 8 years ago

The "items" output by scribe recipes that go into the guild inventory aren't actually items -- they're guild upgrade objects (e.g., the id references /v2/guild/upgrades).

darthmaim commented 8 years ago

Probably too late to change the ingredients/output to the same data structure as objectives/rewards of achievements ({type: "awesome", id: 42, count: 1}). /v2/recipez plz.