search

arenanet / api-cdi

Collaborative Development Initiative for Public APIs
253 stars 41 forks source link

Parent skill and child skills #204

Open Archomeda opened 8 years ago

Archomeda commented 8 years ago

After seeing some inconsistencies and weirdness that involves flip_skill and various profession skills, I thought it might be better to have properties like parent_skill and child_skills.

This can improve the way how Druid glyphs work (see #203) and also the various elementalist glyphs that change depending on the attunement. For example the Glyph of Storms:

Currently, only the Glyph of Storms is linked to Ice Storm through flip_skill. The rest are somewhere linked in the void at the moment.

I'm not sure if there are more skills that function like these glyphs, but I can imagine that if there are any, they can benefit from this too.

Archomeda commented 6 years ago

Now that .subskills has become a thing, it's possible to traverse the skills in a easier way. However, there's no way to go to a parent skill from a sub skill from what I've seen. It would be nice to have them linked both ways.

R0dolf commented 6 years ago

Hi there Bringing back this topic Adding a reference to the parent skill would be really great indead Moreover, it would be great to have type property more accurate for the sub skills. For example, if we look at Tornado, we know it's a transformation skill because of transform_skills. But when we look at the sub skills, all we know is they are Bundle type Same goes for transformations like shrouds where we have nothing about sub skills or the parent skill (depending of what we're looking at).