arenanet / api-cdi

Collaborative Development Initiative for Public APIs
253 stars 41 forks source link

Daily achievement 2817 doesn't exist #236

Closed robertluedke closed 8 years ago

robertluedke commented 8 years ago

Achievement 2817 got it into the daily PvP achievements today, but https://api.guildwars2.com/v2/achievements/2817 only returns: {"text":"no such id"}

darthmaim commented 8 years ago

If I remember correctly the achievements are only whitelisted once per day, so it might take some time for new achievements to appear.

robertluedke commented 8 years ago

If this is true, this is bad practice. You cannot say, you'll get some great stuff in this house, but you have to wait until it is build... Instead you shouldn't say something about it or better do some preparations to be sure, it is there, when the time will come, when it is needed. :D

tivac commented 8 years ago

Dunno if this is a whitelisting issue, I'll see if I can find out.

@robertluedke Disagree. We use whitelisting to prevent accidentally leaking unreleased information via APIs. You may not like it but it doesn't make it a bad practice.

robertluedke commented 8 years ago

Yeah, @tivac I agree with you. Whitelisting to prevent leaking is fine, but it should be working also on day 1 for a new one, not that the whitelisting happens so much later after pointing to this data somewhere else. That's all, what I wanna say. :)

darthmaim commented 8 years ago

Just found the source for my comment above:

I think that was a cache issue — the daily achievements are automatically whitelisted (they bypass the normal manual approval). The master list of whitelisted achievements was probably just cached for a while after reset (it’s got a fairly long cache duration since it only updates once/day at most — since usually it’s a manual process). IIRC this happened because there were new dailies released yesterday, so this shouldn’t happen too frequently.

lye commented 8 years ago

Sorry! Been out all week and haven't been attending to the whitelist queue. Just whitelisted this achievement :>

robertluedke commented 8 years ago

Thank you, very much! :)