search

arenanet / api-cdi

Collaborative Development Initiative for Public APIs
257 stars 41 forks source link

Add game_types for /v2/traits facts #558

Open darthmaim opened 7 years ago

darthmaim commented 7 years ago

Example: Assassin's Presence (1802) contains these 2 facts:

{
  "type": "AttributeAdjust",
  "icon": "https://render.guildwars2.com/file/E1E7C4D3A6E62F3D5C9F627CE8175BFB0C614CBE/156652.png",
  "value": 225,
  "target": "CritDamage"
},
{
  "type": "AttributeAdjust",
  "icon": "https://render.guildwars2.com/file/E1E7C4D3A6E62F3D5C9F627CE8175BFB0C614CBE/156652.png",
  "value": 150,
  "target": "CritDamage"
}

The first +225 CritDamage is the PvE fact, +150 is for the WvW and PvP (see wiki).

The facts should include an additional game_types property that is an array of gamemodes that fact is available in. /v2/items already contains a property game_types: "Activity" | "Dungeon" | "Pve" | "Pvp" | "Wvw".

itsdouges commented 7 years ago

Ah! Yeah! This would be really helpful.