arenanet / api-cdi

Collaborative Development Initiative for Public APIs
258 stars 41 forks source link

required_access incorrect on /v2/achievements/daily #574

Open thatshaman opened 7 years ago

thatshaman commented 7 years ago

The required_access field on /v2/achievements/daily and /v2/achievements/daily/tomorrow always show GuildWars2 and HeartOfThorns as requirement (even on Core, Heart of Thorns or Path of Fire only achievements)

"required_access": [
 "GuildWars2",
 "HeartOfThorns"
]
Medyro commented 7 years ago

Can i take a guess; you noticed this while trying to update thatshaman.com/tools/daily probably, right?

thatshaman commented 7 years ago

Exactly! Wanted to fix the layout to include the Path of Fire dalies but noticed things were a bit off.

signaturefish commented 7 years ago

For additional fun, multiple types of some daily achievement are listed. I'm assuming that if PathOfFire was available as a required_access value we'd be able to see why (because some dailies are gonna require PoF, due to map access). At the moment, everything needs Core and HoT, which makes it hard to do much useful with this endpoint.

Archomeda commented 6 years ago

Right now, it does include PathOfFire, but it sets them on all dailies regardless of what they actually should be. For example:

    //...
    {
      "id": 3721, // Daily Desert Vista Viewer
      "level": {
        "min": 80,
        "max": 80
      },
      "required_access": [
        "GuildWars2",
        "HeartOfThorns",
        "PathOfFire"
      ]
    },
    {
      "id": 1839, // Daily Kryta Vista Viewer
      "level": {
        "min": 80,
        "max": 80
      },
      "required_access": [
        "GuildWars2",
        "HeartOfThorns",
        "PathOfFire"
      ]
    },
    {
      "id": 1839, // Daily Kryta Vista Viewer
      "level": {
        "min": 11,
        "max": 79
      },
      "required_access": [
        "GuildWars2",
        "HeartOfThorns",
        "PathOfFire"
      ]
    },
    //...
Archomeda commented 5 years ago

Seems like it's working correctly now with the recent schema update from 2019-05-16T00:00:00.000Z.