arenanet / api-cdi

Collaborative Development Initiative for Public APIs
257 stars 41 forks source link

Festival achievement categories oddities #600

Open Archomeda opened 6 years ago

Archomeda commented 6 years ago

Wintersday achievement categories are not available in any group on the API, but are available in Historical in-game:

Halloween achievement categories are not available in any group on the API, but are available in Historical in-game:

Lunar New Year achievement categories are currently available on the API in the group Historical, but they are currently available under Festivals in-game (but that group seems to be missing in the API):

SAB achievement categories are not available in any group on the API, but are available in Historical in-game (refs #544)

¹Actually not visible in-game either, probably due to them being repeatable and therefore not showing up in-game, just like most of the other uncompleted achievements seem to disappear from the Historical group.


I think this is starting a trend where festival achievement categories are available in the Historical group in the API whenever the respective festival is active in-game, while they should be in the Festivals category (which doesn't exist according to the API). And whenever a festival is inactive in-game, the corresponding achievement categories just vanish from any achievement group in the endpoint /v2/achievements/groups. (edit: Festivals group id seems to be 647D3B02-2302-41F0-88A3-6D88BB6F55CF)

If I'm right about this, then the LNY achievements will follow the same rule as Halloween, Wintersday and SAB when LNY is over.

Maybe it's time for #489 as well? :D