arenanet / api-cdi

Collaborative Development Initiative for Public APIs
257 stars 41 forks source link

/v2/colors is missing Colors avaiable in Kits #624

Closed Medyro closed 6 years ago

Medyro commented 6 years ago

Where... "Kit" refers to Total Makeover Kit and partially Self-Style Hair Kit.

At the moment only a subset of the Colors avaiable in Kits seem to appear in /v2/colors. The other Colors (as e.g. Medium Blue, Foofoo, Panther Black, Pale Orange/Yellow/..) do not.

It is to be expected /v2/colors to either contain all or none of the, non Kit-Exclusive, Colors.

/v2/colors should at least List all of the non Kit-Exclusive Colors, and not only Part of them.

Legend [missing/total] Lines starting with '+' indicate that the Color is avaiable in both Kits and /v2/colors Lines starting with '-' indicate that the Color is avaiable only in the Kits but is missing in /v2/colors Colors Listed are Limited to those Colors witch are NOT explicitly marked as Exclusive to the Makover Kits. (those withouth the Star) Spelling Mistakes Copyright (c) me. Do not change.

Fur-/Pattern-/Hair- Colors [29/35] +Black +Chocolate +Sienna +Pale +Sand +White -Panther Black -Burnt Toast -Coffee -Red Brown -Foofoo -Red Orange -Tiger Orange -Yellow -Pale Orange -Light Orange -Mesh -Soft Yellow -Pale Yellow -Fried -Pale Orche -Orche -Verry Dark -Dark Gray -Dark Bobcat -Medium Bobcat -Bobcat -Dark Sand -Tiger White -Peach Gray -Gray Wolf -Payne's Gray -Blue Gray -Snow Gray -Snow White

Eye- Colors [36/43] +Black +Gray +White +Orange +Red +Pink +Purple -Autumn Brown -Chestnut Brown -Medium Brown -Light Brown -Pale Brown -Goldenrot -Pale Yellow -Yellow -Bright Yellow -Sunlight -Pale Orange -Bright Orange -Light Orange -Loud Organe -Dark Red -Pale Pink -Pale Purble -Bright Purple -Light Purple -Bluebell -Dark Blue -Bright Blue -Ice Blue -Light Blue -Sky Blue -Blue -Medium Blue -Blue Green -Pale Blue -Pale Blue Green -Green Mist -Mint Green -Pale Green -Light Green -Medium Green -Leaf Green

Acessory- Colors [0/21] +Orchid +Royal Rose +Glory +Tea Jeans +Stream +Winter Sky +Jalapeno +Limette +Deep Maple +Autumn +Salmon +Apricot +Antique Gold +Pottery +Clay +Camel +Dijon +Ebony +Tarnished Steel +Stone +Matte
Aonwy commented 6 years ago

There are names that belong in both dye and color categories, but this list only exposes dyes that are available in-game. Anything else that appears to be missing, is so because it is not a dye and not something acquirable by players. There are actually no colors in that list, but there are things that use the same text as colors, hence the confusion around hair/eye colors. Technically the endpoint should probably be 'dyes' instead of 'colors', but in the interests of not breaking existent code we are going to leave it alone.

Medyro commented 6 years ago

Even tough it's unfortunate to "hear" that the missing "Color"s can't be added; i do understand that this seemed to have been a misconception on my Side then, now that i know about there being more than one kind of "Color" and that the "Color"s i Listed are to be considered different from the "Dye"s already provided by /v2/colors acordingly.

Thanks for digging and considdering addition either Way. :)