arenanet / api-cdi

Collaborative Development Initiative for Public APIs
257 stars 41 forks source link

/v2/gliders does not respect the requested language #667

Closed TheMrMilchmann closed 3 years ago

TheMrMilchmann commented 4 years ago

According to #182 the endpoint is localized. However, when visiting https://api.guildwars2.com/v2/gliders?ids=all&lang=de all names and descriptions are still in English. (Same for requesting any other language.)

[
  {
    "id": 1,
    "unlock_items": [
      70048
    ],
    "order": 3,
    "icon": "https://render.guildwars2.com/file/5978F84C08E69460B7FD34346745E7183562A35A/951784.png",
    "name": "Black Feather Wings Glider",
    "description": "<c=@reminder>This is only available from the Black Lion Trading Company during limited-time sales.</c>\n\nIf you wear the Black Feather Wings Backpack, speak to a scout in Verdant Brink to receive a free matching Glider.",
    "default_dyes": []
  },
  {
    "id": 3,
    "unlock_items": [
      70009
    ],
    "order": 3,
    "icon": "https://render.guildwars2.com/file/FB9A14C04510096F4E33205AC2DE15BB07ADA0FF/1010543.png",
    "name": "White Feather Wings Glider",
    "description": "<c=@reminder>This is only available from the Black Lion Trading Company during limited-time sales.</c>\n\nIf you wear the White Feather Wings Backpack, speak to a scout in Verdant Brink to receive a free matching glider.",
    "default_dyes": []
  },
  ...
TheMrMilchmann commented 3 years ago

/v2/gliders now respects lang

https://discord.com/channels/384735285197537290/384735523521953792/776967602110201916

Thanks for the fix!