arenasys / sd-tagging-helper

A GUI to help with manual tagging and cropping
233 stars 12 forks source link

Option to change input folder from GUI #17

Closed flesnuk closed 2 years ago

flesnuk commented 2 years ago

I didn't find a way to change the input folder without manually editing the start.sh arguments. Maybe a good time would be after packaging to the output folder. (Infering that you finished with the current dataset and want to go to next one). Possible by adding a button in the package pop-up instead of displaying the File explorer automatically to avoid confussion. (by thinking it is requesting the output folder)

But the best option is having a toolbar with the typical File, View, etc. improving the usability/friendliness of the program.

arenasys commented 2 years ago

Yea, its not ready to be done automatically without side effects, so i left it as a manual only option.

The issue is changing the input folder without changing the staging folder can currently have unexpected results. if you have input_a/1.png and input_b/1.png they will both share the staging metadata file 1.png.json, overriding each other. Also it may be unexpected to have the output data overridden.

Asking for each of the 3 folders from the user is annoying and confusing so theres two options i can think of.

flesnuk commented 2 years ago

The best would be to ask the user to input a name for the dataset they will work on, or just use the name of the input folder as the dataset name. Then you can use that as a way to store in output/datasetname or staging/datasetname

arenasys commented 2 years ago

A dataset name is good solution but i want to try keep everything as straightforward as possible. Having the output+staging folder in the input folder has a few advantages. The datasets would be totally isolated from each other and portable, the structure is easier to understand/manage for the user and the only information the user needs to provide is the input folder. So i will probably go with that

arenasys commented 2 years ago

added in b03599b1e8583b3d0b5ddf2622821a62336da9f3