search

arenaxr / XRBrowser

WebXR for iOS
Mozilla Public License 2.0
10 stars 1 forks source link

App crashes after a while #11

Open nampereira opened 3 years ago

nampereira commented 3 years ago

Steps to reproduce

Unfortunately, the only way we get it to reproduce is by walking around in a large environment (campus building). It eventually crashes throwing an "index out of range error" in file Client->Frontend->Browser->XR->ARKController->XRMetal->XRPlane.swift (see attached image).

The time it takes to crash seems to be related to the size of the environment/number of planes.

Expected behavior

Should not crash.

Actual behavior

It crashes.

Device & build information

Notes

We have a very crude "fix" that we will push in a bit, but definitely not the right way to go about it.

Attachments: image

robomex commented 3 years ago

I did some rough testing on this the past few days.

Device used: 2020 11" iPad Pro with LiDAR "Methodology": I do laps around my apartment running the World Sensing WebXR demo and time how long it takes for the app to crash. Test subjects: WebXR Viewer (latest version on the App Store) and the new XR Browser (I just submitted v1.0 to the App Store for review)

I timed 5 cases of WebXR Viewer crashing running the World Sensing demo. WebXR Viewer crashed all five times and the times to crash were:

image

For XR Browser I stopped timing on the first run after it did not crash after 15+ minutes (i.e. 3x the longest running trial for WebXR Viewer).

image

I'm not 100% convinced this issue is resolved for all use-cases on all devices (e.g. perhaps rescanning my small apartment doesn't yield the failure in XR Browser the way walking around a large area/volume would yield the failure), but I would benefit from others testing v1.0 of XR Browser once it's available on the App Store to check if this issue persists.

If it does, I would appreciate information on the device used to reproduce the crash and rough information on the space scanned when the crash occurred (if it crashes when walking around a campus building, does it crash after exiting the first classroom? Does it crash after scanning 4 large classrooms on a single floor? Does it crash after going down stairs to scan a different level? My intent with these questions, if the issue still exists, is to try and understand if it's a straightforward "square footage" issue, or an elevation issue, or some other environment-related issue).

The commit that appears to have resolved this issue on my end, i.e. for my devices scanning my environment, is: c43991213aa4798feaa718266c912aa7859303b6 But I look forward to help with additional testing after v1.0 of XR Browser is on the App Store.