feat(build3d): allow build3d upload filestore files through auth refactor

arenaxr / arena-web-core

An environment to view and interact in multiuser virtual and augmented reality.

https://docs.arenaxr.org

BSD 3-Clause "New" or "Revised" License

41 stars 28 forks source link

feat(build3d): allow build3d upload filestore files through auth refactor #646

Closed mwfarb closed 5 months ago

mwfarb commented 5 months ago

consolidates jwt reading for ui to auth.js
eliminates 2 third party libs
shares filestore upload from build with build3d

mwfarb commented 5 months ago

@hi-liang Any thoughts on how to organize this better would be super helpful. There is one issue I need help with. I tried to refactor the upload chains of async events well, esp. to be able to trace the resolves, but I could use help getting this updated object to return. https://github.com/arenaxr/arena-web-core/blob/build3d-upload2/static/auth.js#L468

mwfarb commented 5 months ago

Probably the simplest reproducible test is:

Open build page.
Select Image from object type drop down.
Click Upload File & Publish.
After selecting an image and clicking Upload, the desired effect is to return the updated wire object from await uploadSceneFileStore.

mwfarb commented 5 months ago

Adding https://www.w3schools.com/js/js_callback.asp, thanks to @hi-liang !