search

arendajaelu / nestjs-passport-apple

Apple Passport Strategy for Apple Login (dedicated to Nestjs)
MIT License
16 stars 6 forks source link

feat(keyFilePath)!: fix misleading keyFilePath option #5

Closed kdelmonte closed 11 months ago

kdelmonte commented 11 months ago

BREAKING CHANGE (bumped major version)

The keyFilePath does not really expect a file path but the actual file contents. This is a bit confusing and some users have run into it already.

Also, updated README to provide a working example for users.

Fixes #3 and #4.

kdelmonte commented 11 months ago

@arendajaelu , hello! When do you think this could be published to nom?

arendajaelu commented 11 months ago

@kdelmonte Hey Bro, thank you for your contribution, I just published it on npm.js. Could you please check and test it? Much appreciate it.

kdelmonte commented 11 months ago

My pleasure. Thank you for this package! It is a real time saver. Unfortunately, I made a small mistake which I am fixing here: #6.

arendajaelu commented 11 months ago

Thank you for solving that quickly, :) Publishing to npm