search

arendjantetteroo / guzzle-toggl

A Toggl API client based on guzzle
MIT License
88 stars 42 forks source link

Compatibility with V9 api #44

Closed edward-simpson closed 3 months ago

edward-simpson commented 4 months ago

Closes #43

Majority of work to migrate over to the v9 API, but because of Toggl's silly format for migration notes, some of the changes to endpoints actually create duplicate endpoints (because of the changes to include /workspace/{workspace_id}, so I need to go through and de-dupe when I have time).

Creating as a draft pull request until I have time to finalise, but if anyone else wants to jump in in the mean time feel free

arendjantetteroo commented 4 months ago

Thanks, looks good to me. I see that it needs a new major version when we release this.

If anyone can confirm it works for them would be great.

I'm ok with releasing a version that is incomplete and follow with some point releases, as the current version doesn't work anymore anyway.

akhumphrey commented 3 months ago

I've tested these changes against a project with basic Toggl integration and not had any issues.

Admittedly, the project only performs read operations against a ReportsClient (so doesn't represent much in the way of surface area testing), but every little helps 👌🏻

edward-simpson commented 3 months ago

Sorry I've been a bit quiet, work's been hectic, thanks for jumping on this and tidying up my work!