Four files using wrong compiler directive #ifdef EPS8266 instead of #ifdef ESP8266

arendst / Tasmota

Alternative firmware for ESP8266 and ESP32 based devices with easy configuration using webUI, OTA updates, automation using timers or rules, expandability and entirely local control over MQTT, HTTP, Serial or KNX. Full documentation at

https://tasmota.github.io/docs

GNU General Public License v3.0

22.22k stars 4.81k forks source link

Four files using wrong compiler directive #ifdef EPS8266 instead of #ifdef ESP8266 #19207

Closed msedv closed 1 year ago

msedv commented 1 year ago

PROBLEM DESCRIPTION

In these four files #ifdef EPS8266 is used instead of #ifdef ESP8266 - which e.g. broke the MFRC522 functionality between 12.5 and 13.x:

tasmota/tasmota_xdrv_driver/xdrv_10_scripter.ino
tasmota/tasmota_xdrv_driver/xdrv_50_filesystem.ino
tasmota/tasmota_xsns_sensor/xsns_80_mfrc522.ino
CHANGELOG.md

Symptoms in xsns_80_mfrc522.ino: no card detected, no error since SPI isn't opened.

I corrected the files locally and tried to to a git push but get an error 403.

arendst commented 1 year ago

My fault. I’m out until next friday so if you manage to do a PR would be great

msedv commented 1 year ago

Done: https://github.com/arendst/Tasmota/pull/19209