arendst / Tasmota

Alternative firmware for ESP8266 and ESP32 based devices with easy configuration using webUI, OTA updates, automation using timers or rules, expandability and entirely local control over MQTT, HTTP, Serial or KNX. Full documentation at
https://tasmota.github.io/docs
GNU General Public License v3.0
21.73k stars 4.72k forks source link

BLE: fix conflicting log_level definitions #21337

Closed Staars closed 2 months ago

Staars commented 2 months ago

Description:

Fixes an annoying glitch where macros from the nimble framework would override the log level enum of Tasmota with conflicting values. Basically esp-nimble-cpp did always turn on LOG_LEVEL_DEBUG because this macro has a value of 0 in nimbles log header file. This overrides Tasmotas enum LoggingLevels {LOG_LEVEL_NONE, LOG_LEVEL_ERROR, LOG_LEVEL_INFO, LOG_LEVEL_DEBUG, LOG_LEVEL_DEBUG_MORE}; globally.

Valid for every Tasmota firmware that uses esp-nimble-cpp.

Checklist:

NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass