MS5837 and BMP280 functionality for inches water

arendst / Tasmota

Alternative firmware for ESP8266 and ESP32 based devices with easy configuration using webUI, OTA updates, automation using timers or rules, expandability and entirely local control over MQTT, HTTP, Serial or KNX. Full documentation at

https://tasmota.github.io/docs

GNU General Public License v3.0

21.73k stars 4.72k forks source link

MS5837 and BMP280 functionality for inches water #21377

Closed vtHydroponics closed 1 month ago

vtHydroponics commented 2 months ago

Description: Added compatibility with MS5837 and BMP280 to calculate inches of water

Related issue (if applicable): fixes #

Checklist:

[X ] The pull request is done against the latest development branch
[X ] Only relevant files were touched
[X ] Only one feature/fix was added per PR and the code change compiles without warnings
[X ] The code change is tested and works with Tasmota core ESP8266 V.2.7.6
[X ] The code change is tested and works with Tasmota core ESP32 V.3.0.0
[X ] I accept the CLA.

NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass

arendst commented 2 months ago

The goal of a PR is to add functionality with touching as few files as possible.

You're touching files with adding spaces and irrelevant logs. There is even a TSL file change not related to your initial addition.

Pls revisit your PR and make as few changes as possible using the above suggestions.

github-actions[bot] commented 1 month ago

This PR has been automatically marked as stale because it hasn't any activity in last few weeks. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] commented 1 month ago

This PR was automatically closed because of being stale.