arendst / Tasmota

Alternative firmware for ESP8266 and ESP32 based devices with easy configuration using webUI, OTA updates, automation using timers or rules, expandability and entirely local control over MQTT, HTTP, Serial or KNX. Full documentation at
https://tasmota.github.io/docs
GNU General Public License v3.0
21.71k stars 4.72k forks source link

I2S bugfix: webradio crash with invalid url #21446

Closed Staars closed 1 month ago

Staars commented 1 month ago

Description:

It has always be guaranteed to get a crash by providing an invalid url to the web radio command like: i2swr i_am_not_a_valid_webradio_url

This did of course also include copy-paste-errors or former correct url names. Besides every other occasional connection error did lead to a crash too.

  1. Main problem was the audio library, which did no error checking. Addditionally we check now for success in Tasmota as this is possible with this library change.

  2. Removal of some unused code.

Checklist:

NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass