I add support for ThinkSpeak

arendst / Tasmota

Alternative firmware for ESP8266 and ESP32 based devices with easy configuration using webUI, OTA updates, automation using timers or rules, expandability and entirely local control over MQTT, HTTP, Serial or KNX. Full documentation at

https://tasmota.github.io/docs

GNU General Public License v3.0

21.7k stars 4.72k forks source link

I add support for ThinkSpeak #21534

Closed macheloortiz closed 1 month ago

macheloortiz commented 1 month ago

Description:

Related issue (if applicable): fixes #

Checklist:

[ ] The pull request is done against the latest development branch
[ ] Only relevant files were touched
[ ] Only one feature/fix was added per PR and the code change compiles without warnings
[ ] The code change is tested and works with Tasmota core ESP8266 V.2.7.6
[ ] The code change is tested and works with Tasmota core ESP32 V.3.0.0
[ ] I accept the CLA.

NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass

sfromis commented 1 month ago

To me, this looks like you are breaking existing MQTT usage. The most important with a new feature is that it must be entirely optional to enable even when having it in the project code base, and not impede existing usage.

arendst commented 1 month ago

Thx.

Nice demonstration of how not to add features while destroying current/legacy support.

To make this merged first remove all changes to my_user_config.h as they have nothing to do with adding ThinkSpeak Support. Then make the needed changes to the code optional using defines so legacy support is still available.

Looking at the suggested code changes it's a total no-go (Serial.print is the least problem).

s-hadinger commented 1 month ago

I'm sorry but CLA is no even accepted in the PR. Closing for now until it is fixed