search

arendst / Tasmota

Alternative firmware for ESP8266 and ESP32 based devices with easy configuration using webUI, OTA updates, automation using timers or rules, expandability and entirely local control over MQTT, HTTP, Serial or KNX. Full documentation at
https://tasmota.github.io/docs
GNU General Public License v3.0
22.22k stars 4.81k forks source link

Filename for configuration backup #2422

Closed Geitde closed 6 years ago

Geitde commented 6 years ago

This is an issue for all devices. Well, issue may be a hard word here.

When saving the configuration Tasmota uses a friendly name as part of the file name. This is kind of odd, since the configuration is about a device and not one single relay or sensor.

In my opinion the host name should be used here, as it represents the whole device the configuration belongs to. Just keep in mind that the purpose of a friendly name may change at some point, as you no longer have the coffee machine attached to the power socket, but the blender. You change the name to match with alexa and boom. Next time you want to access the settings backup you can´t find it, because the name changed.

Same goes for the topic on all pages. It already shows the device name, but this is not helpful if you e.g.have 20 Sonoff Dual. Below displayed is one of the friendly names, which should be the host name, too, as a friendly name just represents one feature of the hardware and not the entire device.

Just imaging you have multiple webpages with Tasmota open and the pages all say "Sonoff Dual" and below PowerPlug47, PowerPlug33, PowerPlug22, ... Now find the one in the Kitchen. I guess you got my point. It would be easier to use the host name, which could provide a general device location. Like Kitchen, LivingRoom, HomeCinema.

This would increase usability and maintainability alot.

stale[bot] commented 6 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 6 years ago

This issue will be auto-closed because there hasn't been any activity for a few months. Feel free to open a new one if you still experience this problem.

mkh595 commented 5 years ago

@Geitde:

I also prefere to use host name instead of friendly name because in case of diacritics in friendly name is filename unusable.

Friendlyname

I changed two lines in xdrv_01_webserver.ino but I have to modify it after each update. Would be nice if this can be controlled by SetOption parameter.

  // char friendlyname[sizeof(Settings.friendlyname[0])];
  // snprintf_P(attachment, sizeof(attachment), PSTR("attachment; filename=Config_%s_%s.dmp"), NoAlNumToUnderscore(friendlyname, Settings.friendlyname[0]), my_version);
  char hostname[sizeof(Settings.hostname)];
  snprintf_P(attachment, sizeof(attachment), PSTR("attachment; filename=Config_%s_%s.dmp"), NoAlNumToUnderscore(hostname, Settings.hostname), my_version);