search

ares-emulator / ares

ares is a cross-platform, open source, multi-system emulator, focusing on accuracy and preservation.
https://ares-emu.net
Other
945 stars 115 forks source link

CI: Update wpilibsuite signing action for macOS #1538

Open shinra-electric opened 3 months ago

shinra-electric commented 3 months ago

This updates the import signing certificate to the latest version. It should silence several warnings in the actions builds.

Since this is security related, it needs to be thoroughly reviewed.

I noticed that the wpilibsuite repo does not get updated very often, sometimes years between commits. Since this is security related, it might be an idea to switch to an alternative tool that's updated more often. There are a few options including Apple Actions which looks like it's kept up to date on a regular basis.

LukeUsher commented 3 months ago

For audit purposes, the changes between both commits can be viewed here: https://github.com/wpilibsuite/import-signing-certificate/compare/2ac4f44d28045073d23153256efbb4c4b2d8aa22...9e858a4e87d254c4f1d39632ff810d78ee061302