search

ares-emulator / ares

ares is a cross-platform, open source, multi-system emulator, focusing on accuracy and preservation.
https://ares-emu.net
Other
891 stars 110 forks source link

[feature request] support for libretro shaders #182

Closed AbreuEfechou closed 2 years ago

AbreuEfechou commented 2 years ago

please add support for .cg and .cgp shaders https://github.com/libretro/common-shaders

Screwtapello commented 2 years ago

The .cg shader format requires the NVIDIA Cg Toolkit, a legacy no-longer-supported library, so it's unlikely to ever be supported. However, hunterk of RetroArch has kindly ported a bunch of shaders to the Quark format used by ares/higan/bsnes: https://github.com/hizzlekizzle/quark-shaders/

LukeUsher commented 2 years ago

It's worth noting that I now include all license-compatible shaders from quark-shaders in new releases, however, the GPL shaders are not license compatible with ares' ISC and are not bundled.

AbreuEfechou commented 2 years ago

It's worth noting that I now include all license-compatible shaders from quark-shaders in new releases, however, the GPL shaders are not license compatible with ares' ISC and are not bundled.

don't need to bundle them, just support them and the user install the ones which they like

LukeUsher commented 2 years ago

As much as people would like this feature, unfortunately, I'm going to mark it as a "won't fix".

cg/cgp shaders will never be supported due to their reliance on NVIDIA CG, which has been discontinued since April 2012, I don't think it's a good idea to import a huge dependency such as the CG toolkit in the first place, especially not when it has not been officially supported for almost a decade.

ceed0 commented 1 year ago

I wanted to bump this issue to see if there's interest in using new librashader library. To be clear, it's not about cg shaders, but modern slang-shaders.