ares-emulator / ares

ares is a cross-platform, open source, multi-system emulator, focusing on accuracy and preservation.
https://ares-emu.net
Other
940 stars 114 forks source link

[GG] Shining Force Gaiden - Final Conflict - ares hangs upon playing intro scene #259

Open MarcoEstevez opened 2 years ago

MarcoEstevez commented 2 years ago

Ares hangs upon playing intro scene

image

Worth to mention: is the english patched rom, but I tested on ( retroarch - Genesis Plus GX core ) and works perfectly

Shideravan commented 2 years ago

Isn't replicable with non-patched version MD5: 0D4BC152E7AE70457FA74F593E064403CD24AB72

image

BiZkViT96 commented 2 years ago

Won the first battle and returned home. 2021-10-22 04_51_13-Shining Force Gaiden - Final Conflict (Japan) But this is on the Japanese version.

The patched version resets the game even on the initial screen with a girl at the moment when the text should appear. The translated rom works correctly on Emulicious. 2021-10-22 05_21_08-Emulicious - 100% (60 fps)

Translated rom SHA1 9A7370301E16488AAB205C8595169044F90677BA

LukeUsher commented 2 years ago

It appears that this romhack is broken because it accidentally triggers the little-used "bank shift" functionality within the Sega mapper.

This function is only present in games sized 512Kb using a very specific rom mapper; but this game also is 512kb so we can't rely on size alone to detect this feature.

As bank shift is a specific mapper variant that appears to be rarely used, we should disable bank shift by default, and only enable it for software known to require it: avoiding false triggers like in this scenario.