search

areski / django-admin-tools-stats

Django-admin-tools-stats is a Django admin module that allow you to create easily charts on your dashboard based on specific models and criterias
http://django-admin-tools-stats.readthedocs.org/
Other
291 stars 74 forks source link

Fix timezone #51

Open yihuang opened 5 years ago

areski commented 5 years ago

Hi,

Could you give some context here? It seems you are fixing timezone but also adding a user model, why ?

yihuang commented 5 years ago

Sorry for the confusion, the user field is for my use case. I want non-superuser can only view his own data. I think the change is backward compatible.

areski commented 5 years ago

@PetrDlouhy your opinion on this will be appreciated :) ?

PetrDlouhy commented 5 years ago

I am still confused what is this PR about.

@yihuang Can You please change this PR to include only changes related to single issue (and move the other changes to separate PR if needed) and change the title and description accordingly?

yihuang commented 5 years ago

@PetrDlouhy OK, Just done that ;D

PetrDlouhy commented 5 years ago

@yihuang Why is there the jquery fix? I am not sure what it fixes, and discussion about that should be part of another PR.

yihuang commented 5 years ago

@PetrDlouhy I though django's jquery only expose window.jQuery, but I'm not sure now, so I'm revering this commit for the pull request now.