search

areski / django-nvd3

Django wrapper for nvd3 - It's time for beautiful charts
Other
416 stars 124 forks source link

Usage of nv.d3.min.css instead of src/nv.d3.css #26

Closed euhmeuh closed 9 years ago

euhmeuh commented 10 years ago

The wrong css file was used. Fixed it for performance purpose. You may also want to remove other unused files (e.g. in the lib folder).

areski commented 10 years ago

This fix seems wrong, if you install nvd3 with bower, as done on the demoproject, the css files available will be : 'components/bower_components/nvd3/src/nv.d3.css'

euhmeuh commented 10 years ago

Ok, you're definitely right about bower. As I don't use it I wasn't aware this issue would happen. But for performance purpose, it is better to use the '.min' version of the css file (this is the reason that got me to make this change in the first place). I suppose the nvd3 package doesn't make this file available via bower, so we need to ask the nvd3 author to make nv.d3.min.css available before you can merge my change. I'm looking forward to do a pull request on novus/nvd3 (probably changing the makefile so that the .min file is generated inside the src folder).

areski commented 9 years ago

is this an issue we can close ?

euhmeuh commented 9 years ago

Yes, I don't think anyone cares about such a tiny detail, so go ahead and close it. I don't have the time anymore to do something about this.