search

areski / django-nvd3

Django wrapper for nvd3 - It's time for beautiful charts
Other
416 stars 124 forks source link

Allow kwargs for every series (e.g. disabled=true) and fix sorting of y_axis keys #31

Closed jayme-github closed 10 years ago

jayme-github commented 10 years ago

Tests passing and demoproject looks okay but I'm unsure because I removed various special cases here. Please have a close second look at this.

I mainly wanted to provide extra data for every series to disable some of them by default and did not understand why "series kwargs" are only possible in some cases.

The kwargs handling still looks a little dangerous as series kwargs shadows the kwargs provided as parameter but I'm not sure if this is a problem (maybe it's okay to just rename the parameter as it is not used anyway?).

areski commented 10 years ago

Thanks I committed your patch, great job! I also verified if all those If were still needed and actually we could even get rid of piechart one.

Thanks!