search

areski / python-nvd3

Python Wrapper for NVD3 - It's time for beautiful charts
Other
663 stars 191 forks source link

Update python-slugify to at least 1.2.5 #160

Closed bolkedebruin closed 6 years ago

bolkedebruin commented 6 years ago

Some concerns were raised that python-slugify due to its fixed dependency on GPL'd unidecode was incompliant to the GPL (also making python-nvd3 possibly incompliant). Since version 1.2.5 python- slugify allows an alternative to unidecode which removes those concerns.

See: https://issues.apache.org/jira/browse/LEGAL-362 and: https://github.com/un33k/python-slugify/pull/53

As a side request I would highly appreciate a new release to pypi that pushed this change (and obviously bug fixes etc). The latest is from 2015 so others might appreciate and update as well :-).

Thanks for your consideration.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 81.703% when pulling 636edd88d00239bf4d68a383e6dad1cf0f72cf8e on bolkedebruin:update_slugify into 8e6fd92d63f223a85248d6fc732c5a8c0b6a6e47 on areski:develop.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 81.703% when pulling 636edd88d00239bf4d68a383e6dad1cf0f72cf8e on bolkedebruin:update_slugify into 8e6fd92d63f223a85248d6fc732c5a8c0b6a6e47 on areski:develop.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 81.703% when pulling 636edd88d00239bf4d68a383e6dad1cf0f72cf8e on bolkedebruin:update_slugify into 8e6fd92d63f223a85248d6fc732c5a8c0b6a6e47 on areski:develop.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 81.703% when pulling 636edd88d00239bf4d68a383e6dad1cf0f72cf8e on bolkedebruin:update_slugify into 8e6fd92d63f223a85248d6fc732c5a8c0b6a6e47 on areski:develop.

areski commented 6 years ago

Thanks for the fix! I wonder if we should rather consider removing slugify, the less dependencies the better, actually slugify this is not really bringing much value, the chart name could easily be an autogenerated timestamp (unique ID).

Anyway for now I will merge and keep this open.

bolkedebruin commented 6 years ago

@areski awesome thanks! Do you think it is possible to do a release with this? For us it is blocking graduation to a top level Apache project at the moment (Apache Airflow).

I can have a look at the auto-id’ing. If it doesnt get overly complex, I’ll give it a try.

Cheers

areski commented 6 years ago

Great news that python-nvd3 is used by Apache Airflow WOW!

Perhaps we should put more care in this maintaining it, there is a big gap between develop branch and the master, unfortunately there is a lot of work that still need to be done in order to support the latest development from the nvd3 project https://github.com/novus/nvd3

From now I just cherrypicked your commit on the master and made a quick release 0.15 [https://pypi.python.org/pypi/python-nvd3/0.15.0], hopefully this will help you for the time being.

Cheers!