arethetypeswrong / arethetypeswrong.github.io

Tool for analyzing TypeScript types of npm packages
https://arethetypeswrong.github.io
MIT License
1.18k stars 41 forks source link

fix: expose type info from @arethetypeswrong/core #176

Closed atomicpages closed 3 months ago

atomicpages commented 3 months ago

Addresses #175. Did a sanity check using the CLI and the exports are still happy:

image
changeset-bot[bot] commented 3 months ago

🦋 Changeset detected

Latest commit: 51eaeb795f22b7bf20acb120dac36555a5cc300a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages | Name | Type | | ------------------------- | ----- | | @arethetypeswrong/core | Minor | | @arethetypeswrong/cli | Minor | | @arethetypeswrong/history | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

andrewbranch commented 3 months ago

Hey, thanks for the PR, but this is already working as intended. Adding "types" under "exports" does not change anything, and I don’t intend to support Node.js or TypeScript configurations that need top-level "main" or "types". All the types are already exposed to anyone using correct, up to date tsconfig settings. Here's an example showing it working: https://www.typescriptlang.org/play/?target=99&moduleResolution=99&module=200#code/JYWwDg9gTgLgBAbzgBQIYGMDWqDmBTAGjgEEA7VAGwE8BnYGuAXzgDMoIQ4AiAAVSjwwAFoKpg8NAO7tSOAPTpoeLgG4AUGtJ5JKDNnwAKBIyJcWECF1MBGAHQAmWwGYuASnUATPOgr88cCkE4VAAuEnJqOhp1VFswdgAjQJAaAG0ABgBdW0xgUg8VIA